AB-705 mandatory code_verifier for public client#17
Open
purbopanambang wants to merge 1 commit intoAccelByte:masterfrom
Open
AB-705 mandatory code_verifier for public client#17purbopanambang wants to merge 1 commit intoAccelByte:masterfrom
purbopanambang wants to merge 1 commit intoAccelByte:masterfrom
Conversation
AB-705 mandatory ccode-verifier and remove checking auth header on public client
purbopanambang
commented
Jul 19, 2019
| } | ||
|
|
||
| func (s *Server) handleAuthorizationCodeRequest(w *Response, r *http.Request) *AccessRequest { | ||
| auth, err := CheckBasicAuth(r) |
Author
There was a problem hiding this comment.
Please help me to review @anggorodewanto @thoriqsatriya @banukusuma @rjjatson @desniaak
| var codeVerifier string | ||
| // Optional PKCE support (https://tools.ietf.org/html/rfc7636) | ||
| if codeVerifier = r.Form.Get("code_verifier"); len(codeVerifier) == 0 { | ||
| if s.Config.RequirePKCEForPublicClients && publicClient { |
There was a problem hiding this comment.
Just curious, is RequirePKCEForPublicClients configurable? What if it's set to false?
There was a problem hiding this comment.
it will not check the PKCE challenge / verifier if it's not enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB-705 mandatory code-verifier and remove checking auth header on public client